[Mesa-dev] [PATCH] ac/surface/gfx6: Don't force a tile index for fmask.

[Marek Olšák]

Yes. This is the correct fix. Thanks!

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Mon, May 21, 2018 at 9:47 AM, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
wrote:

> The bpe of the fmask often differs from the bpe of the main
> surface. On SI that means it has to get a different tile
> index.
>
> addrlib is capable of figuring this out itself, so just pass
> -1 instead to let it know that it is not preset.
>
> Fixes: 9bf3570fed0 "ac/surface/gfx6: compute FMASK together with the color
> surface"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106511
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106499
> ---
>  src/amd/common/ac_surface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c
> index d7da9950256..b50157cdb9a 100644
> --- a/src/amd/common/ac_surface.c
> +++ b/src/amd/common/ac_surface.c
> @@ -868,7 +868,7 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib,
>                 fin.numSlices = AddrSurfInfoIn.numSlices;
>                 fin.numSamples = AddrSurfInfoIn.numSamples;
>                 fin.numFrags = AddrSurfInfoIn.numFrags;
> -               fin.tileIndex = AddrSurfInfoOut.tileIndex;
> +               fin.tileIndex = -1;
>                 fout.pTileInfo = &fmask_tile_info;
>
>                 r = AddrComputeFmaskInfo(addrlib, &fin, &fout);
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180522/7c1c0e78/attachment.html>