[Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

[Emil Velikov]

On 4 April 2018 at 15:48, Lionel Landwerlin
<lionel.g.landwerlin at intel.com> wrote:
> On 15/03/18 16:03, Emil Velikov wrote:
>
>> Spec says "OpenGL 3.0 is required" so GLL + GLC should become 30
>> Wrt GLES side the spec does not mention anything - is that ES1, ES2,
>> which version etc.
>> Worth keeping it simple and update the spec to say ES2+?
>
>> The patch implements Enable/Disable, yet IsEnabled is missing.
>
> Actually the gl.xml was set to enable it for GL/GLES2, although written
> against the ES3 spec.
>
The "supported" section in the XML should reflect the supported API.
I don't think it supports gles3 or any other form of explicit version check.

The version checks are only on mesa's extensions_table.h. IIRC that
one is there because some apps assume that the extension is advertised
only if all the dependencies are met.
Layman example: I need GL3.0 and extension FOO. Since the FOO already
requires GL3.0, I can omit the GL3.0 check.

Since the spec says GL 3.0 and (any) GLES, I'd make the line "30, 30, ES1, ES2"

HTH
Emil