[Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

Ilia Mirkin imirkin at alum.mit.edu
Fri Apr 24 06:14:03 PDT 2015


The extension is currently marked as GLC, so that equates to dummy_true right?

On Fri, Apr 24, 2015 at 9:00 AM, Brian Paul <brianp at vmware.com> wrote:
> Yes, I second that.
>
> -Brian
>
>
> On 04/24/2015 04:29 AM, Marek Olšák wrote:
>>
>> I'd enable this if at least GLSL 1.30 was supported. I think drivers
>> like r300, nv30, i915, and svga shouldn't get this.
>>
>> Marek
>>
>> On Fri, Apr 24, 2015 at 3:42 AM, Dave Airlie <airlied at gmail.com> wrote:
>>>
>>> From: Dave Airlie <airlied at redhat.com>
>>>
>>> I'm not sure if we shouldn't enable this everywhere
>>> and rip out the API checks,
>>>
>>> discuss,
>>>
>>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>>> ---
>>>   src/mesa/state_tracker/st_extensions.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/mesa/state_tracker/st_extensions.c
>>> b/src/mesa/state_tracker/st_extensions.c
>>> index 25932dd..d22fc4f 100644
>>> --- a/src/mesa/state_tracker/st_extensions.c
>>> +++ b/src/mesa/state_tracker/st_extensions.c
>>> @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen,
>>>      extensions->ARB_half_float_vertex = GL_TRUE;
>>>      extensions->ARB_internalformat_query = GL_TRUE;
>>>      extensions->ARB_map_buffer_range = GL_TRUE;
>>> +   extensions->ARB_shader_subroutine = GL_TRUE;
>>>      extensions->ARB_texture_border_clamp = GL_TRUE; /* XXX temp */
>>>      extensions->ARB_texture_cube_map = GL_TRUE;
>>>      extensions->ARB_texture_env_combine = GL_TRUE;
>>> --
>>> 2.1.0
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=XRYVFi3aEE45uP7Dd2aDjVFxFlW0ISsAIkGKCqEdgBg&s=l-01_HHXxTEZG4GOKVmF6iExtIt4HWaU7JFFrj5YaZ4&e=
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>>
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=XRYVFi3aEE45uP7Dd2aDjVFxFlW0ISsAIkGKCqEdgBg&s=l-01_HHXxTEZG4GOKVmF6iExtIt4HWaU7JFFrj5YaZ4&e=
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list