[Mesa-dev] [PATCH 2/3] glsl: add fallthrough comment on switch

Martin Peres martin.peres at linux.intel.com
Tue Apr 21 00:48:11 PDT 2015



On 21/04/15 08:37, Matt Turner wrote:
> On Mon, Apr 20, 2015 at 10:27 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>   src/glsl/linker.cpp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
>> index b6baa5d..08b4137 100644
>> --- a/src/glsl/linker.cpp
>> +++ b/src/glsl/linker.cpp
>> @@ -2571,6 +2571,7 @@ add_interface_variables(struct gl_shader_program *shProg,
>>                var->data.location != SYSTEM_VALUE_VERTEX_ID_ZERO_BASE &&
>>                var->data.location != SYSTEM_VALUE_INSTANCE_ID)
>>            continue;
> The continue should be indented.

Indeed, with the indent, this is:

Reviewed-By: Martin Peres <martin.peres at linux.intel.com>
>
>> +         /* FALLTHROUGH */
>>         case ir_var_shader_in:
>>            if (programInterface != GL_PROGRAM_INPUT)
>>               continue;
>> --
>> 2.1.0
>>



More information about the mesa-dev mailing list