static libpciaccess?

Alan Coopersmith alan.coopersmith at oracle.com
Thu Mar 14 21:08:26 UTC 2024


https://gitlab.freedesktop.org/xorg/lib/libpciaccess/-/merge_requests/34
should fix this.

	-alan-

On 2/20/24 08:33, Alan Coopersmith wrote:
> Sorry about that - I never build static libraries, so tend not to think
> about them.  I've cc'ed the other developers to see what they think - if
> the single line change is enough or if we'd need to do more there.
> 
>      -alan-
> 
> On 2/19/24 22:51, Peter Fröhlich wrote:
>> Hi Alan,
>>
>> I believe a single-line change from "shared_library" to
>> "both_libraries" would save those of us who need a static library and
>> who don't know meson well quite a bit of time. Yes, to get it working
>> *nicely* additional changes might be necessary (on Debian at least I
>> have to use buildtype=release and also add -D_FORTIFY_SOURCE=0 to then
>> link my application via musl-gcc without any glibc references left)
>> but those are less "universal" I guess?
>>
>> In any case, thanks for the library, it saved me a bunch of work.
>>
>> Cheers,
>> Peter
>>
>> diff --git a/src/meson.build b/src/meson.build
>> index 24eee04..f168a78 100644
>> --- a/src/meson.build
>> +++ b/src/meson.build
>> @@ -38,7 +38,7 @@ endif
>>
>>   inc_src = include_directories('.')
>>
>> -libpciaccess = shared_library(
>> +libpciaccess = both_libraries(
>>     'pciaccess',
>>     [
>>       'common_bridge.c',
> 

-- 
         -Alan Coopersmith-                 alan.coopersmith at oracle.com
          Oracle Solaris Engineering - https://blogs.oracle.com/solaris



More information about the xorg-devel mailing list