[PATCH util-macros v2 4/6] Add XORG_COMPILER_FLAGS to replace XORG_CWARNFLAGS

Gaetan Nadon memsize at videotron.ca
Tue Nov 8 13:35:18 PST 2011


On Thu, 2011-11-03 at 01:19 -0700, Jeremy Huddleston wrote:

> See: https://bugs.freedesktop.org/show_bug.cgi?id=31238
> 
> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> ---
>  xorg-macros.m4.in |   47
> ++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 46 insertions(+), 1 deletions(-)
> 
> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> index 123bdaa..7de333c 100644
> --- a/xorg-macros.m4.in
> +++ b/xorg-macros.m4.in
> @@ -1430,12 +1430,54 @@ m4_foreach([flag], m4_cdr($@), [
>  ])
>  ]) # XORG_TESTSET_CFLAG
>  
> +# XORG_COMPILER_FLAGS
> +# ---------------
> +# Minimum version: 1.16.0
> +#
> +# Defines BASE_CFLAGS to contain a set of command line arguments
> supported
> +# by the selected compiler which do NOT alter the generated code.
> These
> +# arguments will cause the compiler to print various warnings during
> +# compilation AND turn a conservative set of warnings into errors.
> +#
> +# The set of flags supported by BASE_CFLAGS will grow in future
> +# versions of util-macros as options are added to new compilers.
> +#
> +AC_DEFUN([XORG_COMPILER_FLAGS], [ 


I am late for the review, but I looked at the last 3 patches in the
series and I don't see a problem. Overall a nice cleanup as well.

So I should soon be seeing an xserver patch replacing CWARNFLAGS with
BASE_CFLAGS.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111108/64506406/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111108/64506406/attachment.pgp>


More information about the xorg-devel mailing list