<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.32.2">
</HEAD>
<BODY>
On Thu, 2011-11-03 at 01:19 -0700, Jeremy Huddleston wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#3c3c3c">See: <A HREF="https://bugs.freedesktop.org/show_bug.cgi?id=31238">https://bugs.freedesktop.org/show_bug.cgi?id=31238</A></FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">Signed-off-by: Jeremy Huddleston <<A HREF="mailto:jeremyhu@apple.com">jeremyhu@apple.com</A>></FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">---</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c"> xorg-macros.m4.in | 47 ++++++++++++++++++++++++++++++++++++++++++++++-</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c"> 1 files changed, 46 insertions(+), 1 deletions(-)</FONT></TT><BR>
<BR>
<TT><FONT COLOR="#3c3c3c">diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">index 123bdaa..7de333c 100644</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">--- a/xorg-macros.m4.in</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+++ b/xorg-macros.m4.in</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">@@ -1430,12 +1430,54 @@ m4_foreach([flag], m4_cdr($@), [</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c"> ])</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c"> ]) # XORG_TESTSET_CFLAG</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c"> </FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# XORG_COMPILER_FLAGS</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# ---------------</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# Minimum version: 1.16.0</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+#</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# Defines BASE_CFLAGS to contain a set of command line arguments supported</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# by the selected compiler which do NOT alter the generated code. These</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# arguments will cause the compiler to print various warnings during</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# compilation AND turn a conservative set of warnings into errors.</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+#</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# The set of flags supported by BASE_CFLAGS will grow in future</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+# versions of util-macros as options are added to new compilers.</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+#</FONT></TT><BR>
<TT><FONT COLOR="#3c3c3c">+AC_DEFUN([XORG_COMPILER_FLAGS], [</FONT></TT> <BR>
</BLOCKQUOTE>
<BR>
I am late for the review, but I looked at the last 3 patches in the series and I don't see a problem. Overall a nice cleanup as well.<BR>
<BR>
So I should soon be seeing an xserver patch replacing CWARNFLAGS with BASE_CFLAGS.
</BODY>
</HTML>