[PATCH input-synaptics] tools: add the main include directory

[Gaetan Nadon]

On Wed, 2010-02-10 at 23:21 +0100, Julien Cristau wrote:

> On Wed, Feb 10, 2010 at 12:59:40 -0500, Gaetan Nadon wrote:
> 
> > Header record.h is not found in X11/extensions because -I leading
> > to that directory is missing. I think it was accidently removed
> > when fixing the CFLAGS misuse in an earlier commit.
> > 
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  tools/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 75d22c9..9c9f03c 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -23,7 +23,7 @@ bin_PROGRAMS = \
> >  	synclient \
> >  	syndaemon
> >  
> > -INCLUDES=-I$(top_srcdir)/include/ -I$(sdkdir)
> > +AM_CFLAGS = $(XORG_CFLAGS)
> >  
> >  synclient_SOURCES = synclient.c
> >  synclient_LDFLAGS = -lm $(XI_LIBS)
> 
> So I don't understand this patch.  What's needed here is XTST_1_1_CFLAGS
> or RECORDPROTO_1_13_CFLAGS, not XORG_CFLAGS, which is for the driver.
> 

There is probably a better solution from a semantic point of view. It
will boil down to the same -I... I pushed the patch already as I had an
ack and it was breaking the build. I am ok to change it or feel free to
do it. 


        XI_CFLAGS = -I/home/nadon/xorg/src/include  
        XORG16_CFLAGS = -fvisibility=hidden -I/home/nadon/xorg/src/include/xorg -I/home/nadon/xorg/src/include/pixman-1 -I/home/nadon/xorg/src/include  
        XORG_CFLAGS = -fvisibility=hidden -I/home/nadon/xorg/src/include/xorg -I/home/nadon/xorg/src/include/pixman-1 -I/home/nadon/xorg/src/include  
        XTST_1_1_CFLAGS = -I/home/nadon/xorg/src/include  


So, yes, XTST_1_1_CFLAGS will do it as well. 


> Cheers,
> Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100210/ae5f6d3a/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20100210/ae5f6d3a/attachment.pgp