<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Wed, 2010-02-10 at 23:21 +0100, Julien Cristau wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Wed, Feb 10, 2010 at 12:59:40 -0500, Gaetan Nadon wrote:
> Header record.h is not found in X11/extensions because -I leading
> to that directory is missing. I think it was accidently removed
> when fixing the CFLAGS misuse in an earlier commit.
>
> Signed-off-by: Gaetan Nadon <<A HREF="mailto:memsize@videotron.ca">memsize@videotron.ca</A>>
> ---
> tools/Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index 75d22c9..9c9f03c 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -23,7 +23,7 @@ bin_PROGRAMS = \
>         synclient \
>         syndaemon
>
> -INCLUDES=-I$(top_srcdir)/include/ -I$(sdkdir)
> +AM_CFLAGS = $(XORG_CFLAGS)
>
> synclient_SOURCES = synclient.c
> synclient_LDFLAGS = -lm $(XI_LIBS)
So I don't understand this patch. What's needed here is XTST_1_1_CFLAGS
or RECORDPROTO_1_13_CFLAGS, not XORG_CFLAGS, which is for the driver.
</PRE>
</BLOCKQUOTE>
There is probably a better solution from a semantic point of view. It will boil down to the same -I... I pushed the patch already as I had an ack and it was breaking the build. I am ok to change it or feel free to do it. <BR>
<BR>
<BLOCKQUOTE>
<PRE>
XI_CFLAGS = -I/home/nadon/xorg/src/include
XORG16_CFLAGS = -fvisibility=hidden -I/home/nadon/xorg/src/include/xorg -I/home/nadon/xorg/src/include/pixman-1 -I/home/nadon/xorg/src/include
XORG_CFLAGS = -fvisibility=hidden -I/home/nadon/xorg/src/include/xorg -I/home/nadon/xorg/src/include/pixman-1 -I/home/nadon/xorg/src/include
XTST_1_1_CFLAGS = -I/home/nadon/xorg/src/include
</PRE>
</BLOCKQUOTE>
<BR>
So, yes, XTST_1_1_CFLAGS will do it as well. <BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
Cheers,
Julien
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>