xdm: Changes to 'master'

[Gaetan Nadon]

On Wed, 2010-04-14 at 14:54 -0700, Jeremy Huddleston wrote:

> I wish I caught the AC_CONFIG_MACRO_DIR([m4]) change before xdm-1.1.10 shipped.  I *really* dislike it because it leads to build failures with libtool.  Yes, the ac_define_dir.m4 is good to have in there rather than acinclude.m4, but 'make dist' also packages up a bunch of libtool cruft which can cause build failures.
> 
> If the builder runs 'autoreconf -fvi' from the tarball, the packager's libtool m4 macros will be used, and the builder's libtool will be used!
> 
> I just hit this with the new xdm tarball on Leopard which shipped libtool-1.5.22 ... sure, I can 'rm -rf m4/l{ib,}t*' first, but that should not be needed.
> 

Unfortunate, I just did a few conversions from acinclude.m4 to /m4.

I found a bug report in 2008 regarding this issue:
https://wwws.clamav.net/bugzilla/show_bug.cgi?id=1251

I don't fully understand how it works, but I suspect some projects don't
want to be limited by the lowest common denominator and expect their
packages to just configure & make, and not to be reconfigured. This
allows them to link the code using libtool 2.2 (shipped in /m4) on
platforms that only have 1.5 which is considered buggy.

The xserver has had an m4 dir since April 2009. You should have the same
problem there.


> --Jeremy
> 
> 
> On Mar 15, 2010, at 23:35, Alan Coopersmith wrote:
> 
> > .gitignore          |    5 +++++
> > Makefile.am         |    1 +
> > acinclude.m4        |   45 ---------------------------------------------
> > auth.c              |    4 ++--
> > configure.ac        |    1 +
> > m4/ac_define_dir.m4 |   45 +++++++++++++++++++++++++++++++++++++++++++++
> > 6 files changed, 54 insertions(+), 47 deletions(-)
> > 
> > New commits:
> > commit c9cdd56df50f280e90ba95cfa933222f94ad2677
> > Author: Alan Coopersmith <alan.coopersmith at sun.com>
> > Date:   Mon Mar 15 23:34:04 2010 -0700
> > 
> >    Move m4 macros to m4 subdir as automake/libtool recommend
> > 
> >    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> > 
> > commit b9226288b96f0c5988d2c2f52718674d39803a5e
> > Author: Alan Coopersmith <alan.coopersmith at sun.com>
> > Date:   Mon Mar 15 23:21:30 2010 -0700
> > 
> >    Replace hardcoded NAMELEN of 14 for ancient SysV with MAXNAMELEN
> > 
> >    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> > 
> > _______________________________________________
> > xorg-commit mailing list
> > xorg-commit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/xorg-commit
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100414/7c788a4b/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100414/7c788a4b/attachment.pgp>