<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN"> <HTML> <HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8"> <META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0"> </HEAD> <BODY> On Wed, 2010-04-14 at 14:54 -0700, Jeremy Huddleston wrote: <BLOCKQUOTE TYPE=CITE> <PRE> I wish I caught the AC_CONFIG_MACRO_DIR([m4]) change before xdm-1.1.10 shipped. I *really* dislike it because it leads to build failures with libtool. Yes, the ac_define_dir.m4 is good to have in there rather than acinclude.m4, but 'make dist' also packages up a bunch of libtool cruft which can cause build failures. If the builder runs 'autoreconf -fvi' from the tarball, the packager's libtool m4 macros will be used, and the builder's libtool will be used! I just hit this with the new xdm tarball on Leopard which shipped libtool-1.5.22 ... sure, I can 'rm -rf m4/l{ib,}t*' first, but that should not be needed. </PRE> </BLOCKQUOTE> Unfortunate, I just did a few conversions from acinclude.m4 to /m4. I found a bug report in 2008 regarding this issue: <A HREF="https://wwws.clamav.net/bugzilla/show_bug.cgi?id=1251">https://wwws.clamav.net/bugzilla/show_bug.cgi?id=1251</A> I don't fully understand how it works, but I suspect some projects don't want to be limited by the lowest common denominator and expect their packages to just configure & make, and not to be reconfigured. This allows them to link the code using libtool 2.2 (shipped in /m4) on platforms that only have 1.5 which is considered buggy. The xserver has had an m4 dir since April 2009. You should have the same problem there. <BLOCKQUOTE TYPE=CITE> <PRE> --Jeremy On Mar 15, 2010, at 23:35, Alan Coopersmith wrote: > .gitignore | 5 +++++ > Makefile.am | 1 + > acinclude.m4 | 45 --------------------------------------------- > auth.c | 4 ++-- > configure.ac | 1 + > m4/ac_define_dir.m4 | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 54 insertions(+), 47 deletions(-) > > New commits: > commit c9cdd56df50f280e90ba95cfa933222f94ad2677 > Author: Alan Coopersmith <<A HREF="mailto:alan.coopersmith@sun.com">alan.coopersmith@sun.com</A>> > Date: Mon Mar 15 23:34:04 2010 -0700 > > Move m4 macros to m4 subdir as automake/libtool recommend > > Signed-off-by: Alan Coopersmith <<A HREF="mailto:alan.coopersmith@sun.com">alan.coopersmith@sun.com</A>> > > commit b9226288b96f0c5988d2c2f52718674d39803a5e > Author: Alan Coopersmith <<A HREF="mailto:alan.coopersmith@sun.com">alan.coopersmith@sun.com</A>> > Date: Mon Mar 15 23:21:30 2010 -0700 > > Replace hardcoded NAMELEN of 14 for ancient SysV with MAXNAMELEN > > Signed-off-by: Alan Coopersmith <<A HREF="mailto:alan.coopersmith@sun.com">alan.coopersmith@sun.com</A>> > > _______________________________________________ > xorg-commit mailing list > <A HREF="mailto:xorg-commit@lists.freedesktop.org">xorg-commit@lists.freedesktop.org</A> > <A HREF="http://lists.freedesktop.org/mailman/listinfo/xorg-commit">http://lists.freedesktop.org/mailman/listinfo/xorg-commit</A> _______________________________________________ <A HREF="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</A>: X.Org development Archives: <A HREF="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</A> Info: <A HREF="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</A> </PRE> </BLOCKQUOTE> </BODY> </HTML>