[PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

Hans de Goede hdegoede at redhat.com
Tue Mar 25 07:16:57 PDT 2014


The latest glibc considers _BSD_SOURCE deprecated, leading to the following
warning being issued for pretty much every C-file in the xserver:

In file included from /usr/include/stdint.h:25:0,
                 from /usr/lib/gcc/x86_64-redhat-linux/4.8.2/include/stdint.h:9,
                 from ../include/misc.h:81,
                 from miexpose.c:82:
/usr/include/features.h:145:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
 # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
   ^

I've discussed this with the glibc developers and the prefered way of fixing
this is by also defining _DEFAULT_SOURCE which is the new way of stating
_BSD_SOURCE / _SVID_SOURCE .

Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
 xtrans.pc.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xtrans.pc.in b/xtrans.pc.in
index 90d19b1..b8d135b 100644
--- a/xtrans.pc.in
+++ b/xtrans.pc.in
@@ -6,4 +6,4 @@ includedir=@includedir@
 Name: XTrans
 Description: Abstract network code for X
 Version: @PACKAGE_VERSION@
-Cflags: -I${includedir} -D_BSD_SOURCE @fchown_define@ @sticky_bit_define@
+Cflags: -I${includedir} -D_DEFAULT_SOURCE -D_BSD_SOURCE @fchown_define@ @sticky_bit_define@
-- 
1.9.0



More information about the xorg-devel mailing list