[PATCH 07/20] glamor: Add simple upload/download functions in glamor_transfer

Keith Packard keithp at keithp.com
Wed Mar 19 15:31:02 PDT 2014


Daniel Stone <daniel at fooishbar.org> writes:

> Hi,
>
> On 19 March 2014 05:09, Keith Packard <keithp at keithp.com> wrote:
>> +    glPixelStorei(GL_UNPACK_ROW_LENGTH, byte_stride / bytes_per_pixel);
>
> This isn't natively supported on GLES; it requires
> GL_EXT_unpack_subimage, which isn't available on the vast majority of
> shipping GLES GPUs.

Thanks. Glamor is going to need a lot more sophisticated checks for
supported GL bits now that we're using more of the modern GL APIs.

(I'd also bet it's not a problem in the GPU, and just in the GLES
implementation as the stride stuff is almost certainly done in the
CPU...)

I originally wrote the code without using any of the glPixelStore
parameters, so I can go dig that back out and make it conditional.

> (Yes, I know it's lame: it's seriously my #1 gripe about GLES.)

We're collecting a lot of gripes about GLES...

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140319/382ff8ef/attachment.sig>


More information about the xorg-devel mailing list