[PATCH xserver] ephyr: spurious $() in the Makefile breaks the make 'dist' target

Guillem Jover guillem at hadrons.org
Wed Mar 19 09:51:03 PDT 2014


Hi!

On Wed, 2014-03-19 at 10:29:58 -0400, Gaetan Nadon wrote:
> diff --git a/hw/kdrive/ephyr/Makefile.am b/hw/kdrive/ephyr/Makefile.am
> index 040993c..55320eb 100644
> --- a/hw/kdrive/ephyr/Makefile.am
> +++ b/hw/kdrive/ephyr/Makefile.am
> @@ -50,8 +49,7 @@ DRI_SRCS =			\
>  	ephyrglxext.c		\
>  	ephyrglxext.h		\
>  	ephyrhostglx.c		\
> -	ephyrhostglx.h		\
> -	$()
> +	ephyrhostglx.h
>  endif

One reason to use something (in spirit) like this is to avoid
unnecessary line changes whenever a new entry is appended to the list,
which might also generate less conflicts. I tend to use $(nil) as the
last item in those cases. The other option is to switch the assignment
to “=+”, but that seems more verbose.

Thanks,
Guillem


More information about the xorg-devel mailing list