[PATCH 01/10] ephyr: Deal with non-root visual for window

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> glx will sometimes select a non-root visual, deal with that by
> creating a suitable colormap and using that instead of attempting to
> use the default colormap.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>

Maybe just do:

commit 91dbd0af5bf8712d5b5409d82779cd3351660caf
Author: Eric Anholt <eric at anholt.net>
Date:   Fri Mar 14 13:10:04 2014 -0700

    glx: Make sure we get an FBConfig the root window's visual.
    
    Signed-off-by: Eric Anholt <eric at anholt.net>

diff --git a/hw/kdrive/ephyr/ephyr_glamor_glx.c b/hw/kdrive/ephyr/ephyr_glamor_glx.c
index eaf5654..9903cc7 100644
--- a/hw/kdrive/ephyr/ephyr_glamor_glx.c
+++ b/hw/kdrive/ephyr/ephyr_glamor_glx.c
@@ -313,6 +313,7 @@ ephyr_glamor_get_visual(void)
         GLX_GREEN_SIZE, 1,
         GLX_BLUE_SIZE, 1,
         GLX_DOUBLEBUFFER, 1,
+        GLX_VISUAL_ID, DefaultVisual(dpy, DefaultScreen(dpy)),
         None
     };
     int event_base = 0, error_base = 0, nelements;

I don't know the implications of letting a non-root visual get chosen in
terms of rendering behavior, but it doesn't seem like something we want.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140314/1db8791e/attachment.pgp>