glamor performance regression

[Eric Anholt]

Michel Dänzer <michel at daenzer.net> writes:

> On Mon, 2014-03-10 at 14:10 -0700, Keith Packard wrote:
>> 
>> commit 25be6b384298a7769fedb6d9b5bdc370398c9c95
>> Author: Eric Anholt <eric at anholt.net>
>> Date:   Sun Jan 12 07:18:50 2014 +0800
>> 
>>     glamor: Fix a mismatched glamor_get/put_context().
>>     
>>     We don't call GL in this function any more, so we can just drop the
>>     get.
>>     
>>     Signed-off-by: Eric Anholt <eric at anholt.net>
>>     Reviewed-by: Markus Wick <markus at selfnet.de>
>
> This commit made glamor unusably slow with radeonsi, at least an order
> of magnitude slower than before.
>
> Eric's pending change 'glamor: Drop the set of the context to NULL at
> the end of glamor ops.' fixes the performance regression with Xephyr,
> but obviously doesn't help Xorg. The standalone glamor tree doesn't have
> this problem, even though the corresponding context calls are balanced
> there.
>
> Eric, any ideas?

We need to delete the context unset in EGL, too, and actually fix things
correctly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140313/e00a3bbe/attachment-0001.pgp>