glamor-server subset patch bomb

Markus Wick markus at selfnet.de
Wed Mar 12 14:43:40 PDT 2014


wow, big patch series ...

Patches 3-5, 7-22, 24-27 are:
Reviewed-by: Markus Wick <markus at selfnet.de>

But as 21-22 are very big one, I'd like to see another review from 
someone familiar with the X11 renderings. But the gl code is fine :D

Patches 1, 2, 6, 23 also looks fine for me, but I don't know anything 
about this subsystem.

I'm still a bit in worry about 21-22 as they should be implemented in a 
completely different way imo using textures. But this would require 
glsl130 because of integers.

Am 2014-03-11 22:30, schrieb Eric Anholt:
> keithp said he was tired of the glamor stuff trickling in and wanted
> to just review it all at once and be done.  I know I hate reviewing
> giant patch series, but who am I to argue with someone who says they
> want to do more review?
> 
> This series fixes a bunch of CopyPlane XTS tests in Xephyr, thanks to
> the GC prepare fixes if I remember right.
> 
> There are a few patches that used to be in glamor-server that I
> dropped.  Some were performance ideas that didn't produce measurable
> results (yet -- in one case, it's that I think I misplaced a spans
> patch I used to have, which was a prereq for another change being
> useful).  Others just regressed things.  So, if you've got your own
> glamor branches based off of my glamor-server, be careful not to carry
> that junk around.
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list