[PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

Eric Anholt eric at anholt.net
Sat Mar 8 20:01:13 PST 2014


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Flagged by cppcheck 1.64:
> [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]:
>     (warning) Possible null pointer dereference: extension - otherwise
>     	      it is redundant to check it against null.
> [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622]:
>     (warning) Possible null pointer dereference: extension - otherwise
>     	      it is redundant to check it against null.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

I'm going to be sending out a patch to delete these two functions at
some point, but let's not leave it around until then.  These two patches
are:

Reviewed-by: Eric Anholt <eric at anholt.net>

Not sure about the gamma one -- I haven't looked at the XV stuff yet,
but I need to soon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140308/b0b04dee/attachment.pgp>


More information about the xorg-devel mailing list