[PATCH 1/2] xf86Config: Fix warning: declaration of 'Pointer' shadows a global

Hans de Goede hdegoede at redhat.com
Tue Mar 4 23:38:20 PST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 03/05/2014 02:15 AM, Eric Anholt wrote:
> Hans de Goede <hdegoede at redhat.com> writes:
> 
>> This fixes the following compiler warning:
>> 
>> xf86Config.c: In function 'checkCoreInputDevices': xf86Config.c:1136:18: warning: declaration of 'Pointer' shadows a global declaration [-Wshadow] InputInfoPtr Pointer, Keyboard; ^ In file included from xf86Xinput.h:57:0, from xf86Config.c:66: /opt/xorg/include/X11/extensions/XIproto.h:88:24: warning: shadowed declaration is here [-Wshadow] typedef unsigned char *Pointer;
>> 
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> 
> Looks like keithp just hasn't pusehd the reviewed change for inputproto yet.  I'd rather see that land.

Ok, I'll drop this patch then.

> 
> Patch 2/2 is:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>

Thanks, I'll include this in my next pull-req.

Regards,

Hans
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlMW1GUACgkQF3VEtJrzE/s4OwCghvfrf9+jsKt8wqc5kjNL9nBV
L7gAnjWI5cUuWv3QXKpZws0/CVu3qH3l
=tx2u
-----END PGP SIGNATURE-----


More information about the xorg-devel mailing list