[PATCH 3/3] Require video drivers to report that they support server managed fds

Hans de Goede hdegoede at redhat.com
Tue Mar 4 08:56:19 PST 2014


Hi,

On 03/03/2014 06:01 PM, Alan Coopersmith wrote:
> On 03/ 3/14 08:26 AM, Hans de Goede wrote:
>> This makes how we handle video drivers identical to what we do for input
>> drivers, and this should make live easier for old non kms drivers.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   hw/xfree86/common/xf86platformBus.c | 14 +++++++++++++-
>>   hw/xfree86/common/xf86str.h         |  3 ++-
>>   2 files changed, 15 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/xfree86/common/xf86platformBus.c b/hw/xfree86/common/xf86platformBus.c
>> index 564567e..d241a5f 100644
>> --- a/hw/xfree86/common/xf86platformBus.c
>> +++ b/hw/xfree86/common/xf86platformBus.c
>> @@ -38,6 +38,7 @@
>>   #include <unistd.h>
>>   #include "os.h"
>>   #include "hotplug.h"
>> +#include "systemd-logind.h"
>
> Shouldn't that be in an #ifdef for systemd platforms only?

systemd-logind.h has the ifdef internally and defines (always failing)
stubs for all the systemd_logind functions for non systemd platforms,
this way we can avoid sprinkling #ifdef's all over the place.

Regards,

Hans


More information about the xorg-devel mailing list