[PATCH xf86-input-synaptics 0/8] Various clickpad improvements

[Hans de Goede]

Hi,

On 02/26/2014 06:10 AM, Peter Hutterer wrote:
> On Fri, Feb 21, 2014 at 10:31:36AM +0100, Hans de Goede wrote:
>> Hi Peter, Benjamin et al,
>>
>> The following patchset is the result of me playing with the clickpad on the
>> T440s and trying to make using it a more pleasant experience
>>
>> Patch 1: "Add another third state to TouchpadOff for disabling all but button clicks"
>> Is from bugzilla, I've added this as one of my patches conflicts with it, and
>> it seems ready to go upstream.
>>
>> Patch 2: "Add secondary (top) software buttons area"
>> Is also from bugzilla, some of my patches depend on it, and it too seems ready
>> to go upstream.
>>
>> Patch 3-4 are some cleanup patches
>>
>> Patch 5 is a resend of my earlier "Don't report motion inside soft-button areas"
>> patch, addressing Peter's review comments. I had to make it less effective
>> then before, now it only ignores motion started inside soft-button areas
>> before a click. After a click we switch to cummulative mode, so the coordinates
>> are no longer really absolute and still ignoring motion which seems to be
>> inside the soft-button area then breaks click + drag behavior.
>>
>> Still this is a useful patch to have as it avoids accidental cursor movement
>> before the click.
>>
>> Patch 6: "Ignore motion the first X ms after a clickpad click"
>> Is a new patch addressing accidental movement during and after the click,
>> this fixes my #1 anoyance with clickpads, where 2 out of 3 clicks turn into
>> a click + drag unless I hold my finger really really still.
>>
>> Patch 7: "On button down update cumulative to current x and y, instead of previous"
>> Is hard to summarize, see the patch itself.
>>
>> Patch 8: "Wait for *new* coordinates on a clickpad click before reporting the click"
>> Is equally hard to summarize, and may be somewhat controversial, which is why
>> I made this the last patch in the set :)
>
> I've pushed the patches to master now, after removing the property support
> from patch 6 and rebasing it on top of current master (few conflicts,
> nothing exciting).
>
>     ac78616..bbe4c56  master -> master
>
> Let's see what the feedback is and then we can work from there

Thanks!

Regards,

Hans