[PATCH 1/3] Standartize on C99 inline

Tomas Carnecky tom at dbservice.com
Sat Mar 21 00:57:25 PDT 2009


On Mar 20, 2009, at 7:37 PM, Rémi Cardona wrote:

> Tomas Carnecky <tom at dbservice.com>Tomas Carnecky a écrit :
>> The current code uses a mix of inline, __inline, __inline__ and  
>> _X_INLINE.
>> Standartize on C99 inline, but add AC_C_INLINE to configure.ac to  
>> take care
>> of old compilers. Also remove reference to _X_INLINE in doc/c- 
>> extensions.
>
> Why bother with inlining in the first place? Modern compilers are
> supposed to be much smarter about this, making explicit "inline" moot
> and sometimes counter-productive.

I didn't judge the usefulness of the keyword. There indeed are a few  
places where 'inline' seems superfluous, but it still has its use for  
example in headers (static inline).

tom


More information about the xorg-devel mailing list