[PATCH] glx: Replace broken GLX visual setup with a fixed "all" mode.

[Peter Åstrand]

On Mon, 9 Feb 2009, Colin Guthrie wrote:

>> With trying to match depths so that you didn't end up with a depth 24
>> fbconfig for the 32-bit composite visual, I broke the alpha bits on the depth
...
> Applying this patch gives me back compiz.
>
> I'd nominate this for 1.6 soon, just in case Keith has a merging fit and
>  grabs the other one by itself.

This affects Xvnc as well. We had a problem several years ago, with Xorg 
6.8.2: See 
http://lists.freedesktop.org/archives/xorg/2005-June/008313.html . The 
latest 1.5 and 1.6 versions of xserver (ie without this patch) seems to 
have the same problem. For example, older versions of Wine crashes upon 
startup.

I've been able to apply this patch 
(619c4d60eb3a8a51a8300ccf8ab5b98a688e6e12) plus the "Don't match fbconfigs 
to visuals with mismatched channel masks" one 
(5100d829a4d71ce4a9fbc2b81694a1fb90066ccf) to the 1.6 branch, and it seems 
to solve the problems with Wine. So I'm positive to cherrypick this one 
for the 1.6 branch.

For 1.5.3, however, these patches doesn't solve the Wine crash. In fact, 
they make the problem worse. After applying, glxinfo complains:

Error: couldn't find RGB GLX visual

Plus:

$ glxgears
Error: couldn't get an RGB, Double-buffered visual

Of course, this might very well be a problem specific to Xvnc. The visual 
setup is in 
http://vnc-tight.svn.sourceforge.net/viewvc/vnc-tight/trunk/unix/xserver/hw/vnc/xvnc.cc?view=markup 
. Most of the code has been copied from Xvfb. I guess I need to put myself 
in GLX mood to understand what's going on, just like I did 4 years ago, 
but if anyone has an idea...


Regards, 
---
Peter Åstrand		ThinLinc Chief Developer
Cendio AB		http://www.cendio.com
Wallenbergs gata 4
583 30 Linköping	Phone: +46-13-21 46 00