[Intel-gfx] [PATCH] drm: Move plane helpers into drm_kms_helper.ko

[Daniel Vetter]

On Tue, Jun 3, 2014 at 4:44 PM, Matt Roper <matthew.d.roper at intel.com> wrote:
> On Tue, Jun 03, 2014 at 03:38:56PM +0200, Daniel Vetter wrote:
>> The drm core shouldn't depend upon any helpers, and we make sure this
>> doesn't accidentally happen by moving them into the helper-only
>> drm_kms_helper.ko module.
>>
>> Cc: Matt Roper <matthew.d.roper at intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> Are there any KMS drivers that don't 'select DRM_KMS_HELPER' in their
> Kconfig today?  From a quick grep + cscope it looks like radeon and
> vmwgfx don't select the helper library.
>
> Since drm_crtc_init() is part of the helper library now (since it
> creates a helper-created primary plane), I think those drivers either
> need to select the helper in their Kconfig to get a proper build, or
> they need to be updated to provide their own primary planes and call
> drm_crtc_init_with_planes(), right?

Radeon definitely uses the crtc helpers, so should have the dependency
somewhere. vmwgfx might indeed be broken now a bit. I'll wait for the
0-day kernel test build farm to confirm that ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch