X Segmentation fault with i810

[Adam Jackson]

On 1/3/12 12:49 PM, Chris Wilson wrote:
> On Tue, 03 Jan 2012 12:02:43 -0500, Adam Jackson<ajax at redhat.com>  wrote:
>> On 12/30/11 12:34 AM, Jeff Chua wrote:
>>
>>> How can I go about to help debug this?
>>
>> The i810 driver probably needs the equivalent fix as:
>>
>> http://cgit.freedesktop.org/xorg/driver/xf86-video-cirrus/commit/?id=f422d0c38b0befdb2152215ab05d0d14f3da3ed9
>
> The i810 driver uses vgaHWSetMmioFuncs() rather than SetStdFuncs, and so
> leaves hwp->io uninitialised. That pointer is then dereferenced by
> DACDelay() (as it uses pci_io_read8 irrespective of mmio/std funcs) during
> the vgaHWSaveColormap(). At which point, I'm far beyond my comfort zone...
> -Chris
>

Oof, okay, nice find.  DACDelay needs to not do that, or at least, not 
unconditionally.  I'll look into it.

- ajax