[PATCH] SIGSEGV: Silicon Motion Xvideo

[Francisco Jerez]

Krzysztof Halasa <khc at pm.waw.pl> writes:

> Hi,
>
> the SMI driver segfaults when I try to run mplayer -vo xv. I haven't
> investigated too much, perhaps it's caused by the initial video window
> being placed off screen. This is a really old Lynx 3DM (SM720 or
> something), a virtual screen (with traditional mouse panning), single
> CRTC output.
>
> The following fixes the SIGSEGV, though I'm not sure if it's the optimal
> fix. Not sure about possible corner cases either.
>
> Obviously the driver segfaults because crtc is set to NULL in
> xf86_crtc_clip_video_helper() called just before the assignments.
>
> Fedora 13 driver, the same with current git version = 1.7.4.
>
Something like the attached patch would be preferred (there's no need to
set up the overlay if the destination area isn't going to be visible
anyway).

Could you please reply with a 'Tested-by' line ([1]) if it works for
you?

[1] http://xorg.freedesktop.org/wiki/Development/Documentation/SubmittingPatches

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smi_offscreen_overlay.patch
Type: text/x-diff
Size: 957 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20100616/739aad93/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20100616/739aad93/attachment.pgp>