[PATCH] Compiler warnings cleanups

Alex Deucher alexdeucher at gmail.com
Tue Feb 9 13:36:14 PST 2010


On Fri, Feb 5, 2010 at 9:53 AM, Matthew W. S. Bell
<matthew at bells23.org.uk> wrote:
> Hi,
> I attach a patch that fixes various compiler warnings related to
> strict-aliasing, and some whitespace cleanups. I'm sure following
> strict-aliasing rules is not of great import, but the warnings were loud
> and the fixes trivial.

NACK on the white space changes.  The white space in atombios.h messy,
but keeping it as is makes it easier to merge in upstream changes.
The ddx atom pll code should just be cleaned up to use a union like
the other atom functions.

Alex



More information about the xorg mailing list