[PATCH] xrandr: Remove test against RANDR_MAJOR/RANDR_MINOR, already done by configure script

Rémi Cardona remi at gentoo.org
Wed Nov 4 07:42:32 PST 2009


Le 04/11/2009 14:28, Yann Droneaud a écrit :
> xrandr.c uses structures defined in<X11/extensions/Xrandr.h>
> provided by 'libXrandr' package but tests structures availability
> through RANDR_MAJOR/RANDR_MINOR defined in<X11/extensions/randr.h>
> provided by 'randrproto' package.
>
> Sometimes they are not in sync so it's safer to rely on checks made
> by configure script through pkg-config.
>
> In my test case, XRRPanning structure is not defined in Xrandr.h,
> RANDR_MAJOR is 1 and RANDR_MINOR 2 but xrandr.c try to use it anyway.
> (for the record, XRRPanning was added in libXrandr-1.2.91).

configure.ac deps on "xrandr >= 1.3".

Reviewed-by: Rémi Cardona <remi at gentoo.org>

I'll push it to master in a few days if no-one objects.

Cheers,

Rémi



More information about the xorg mailing list