xf86-video-intel : SDVO TV out with Component output: proposing a fix

[Jacques, Hugo]

> > I am using an Add2 card with a CH7021 on SDVO-B (component output =
> CVBS) and a CH7307 for DVI-D on SDVO-C.
> 
> CVBS is composite output, component is YPrPb.

You are absolutely right.  Should have read my e-mail once more before sending ;)

> > Launching X with a VGA monitor connected to the Mobo and a plain old TV
> set to the Add2's CVBS, the TV gets no signal.
> >
> > In the Xorg.0.log, I got:
> >
> > (WW) intel(0): SDVOB: Unknown SDVO output type (0x0400)
> 
> Interesting, this looks violate SDVO spec. As device shouldn't have xxxx1
> output
> unless it has xxxx0 output, and only one TV output, so 0x0400 (CVBS1)
> should always
> be invalid. But real hw vendor could possibly break this as your case.
> 

Actually, because the code to dump the flag in case of unknown type is not little-endian friendly, an unknown type of 0x0400 in the log actually means 0x0040 which is really CVBS0.  There might not be any SDVO spec violation after all.

	memcpy (bytes, &flag, 2);
	xf86DrvMsg(intel_output->pI2CBus->scrnIndex, X_WARNING,
		   "%s: Unknown SDVO output type (0x%02x%02x)\n",
		   SDVO_NAME(dev_priv),
		   bytes[0], bytes[1]);

> >
> > In i830_sdvo.c, function i830_sdvo_output_setup, it seems that the cases
> with flag = SDVO_OUTPUT_CVBS0 or SDVO_OUTPUT_CVBS1 or SDVO_OUTPUT_SVID1
> are not handled.
> >

> > Feel free to integrate it. (Should I be entering this into Bugzilla?)
> >
> 
> Looks ok to me, except it's not in diff format.
> Anyway I'll try to integrate it. Thanks.
> 

I will post a patch for CVBS0 in the right format at http://bugs.freedesktop.org/show_bug.cgi?id=20947

This electronic message may contain proprietary and confidential information of Verint Systems Inc., its affiliates and/or subsidiaries.
The information is intended to be for the use of the individual(s) or
entity(ies) named above.  If you are not the intended recipient (or authorized to receive this e-mail for the intended recipient), you may not use, copy, disclose or distribute to anyone this message or any information contained in this message.  If you have received this electronic message in error, please notify us by replying to this e-mail.