XI2 pull warning

[Peter Hutterer]

you're certainly keeping me busy :) thanks for all those reports 

On Sat, May 30, 2009 at 10:59:28AM -0400, Thomas Jaeger wrote:
> 
> Peter Hutterer wrote:
> > On Thu, May 28, 2009 at 02:54:22PM -0400, Thomas Jaeger wrote:
> >> Thanks for the work you've put into this.  I haven't spent a lot of time
> >>  testing the new code, but here are my first impressions.  You're
> >> probably aware of most of the issues below already, but I'll mention
> >> them just in case.
> >>
> >> * The biggest issue for me right now is reporting of XI1 (see the
> >> attached test program).  XSelectExtensionEvents and
> >> XGrabDevice/XGrabDeviceButton will only report press events; motion and
> >> release events are lost.
> > 
> > Fixed. missing mask assignment in the case of an explicit passive grab.
> Thanks, this is working now.  However, xournal is still won't accept any
> input (unless patched) because it discards events due to device_state
> not being set correctly.

confirmed. I need to write a simple test program to check what exactly is
going on there, I haven't found the exact source for the bug yet.
 
> >> * A driver sending a proximity event crashes the server.
> > 
> > Fixed, thanks. GetProximityEvents still had the valuator event calculation
> > in there and returned a wrong number of events. That, an an uninitialized
> > pointer that was only triggerd for proximity events. Both fixes pushed.
> Thanks, this is mostly working now.  There are still instances where
> proximity events lead to a crash, see the attached gdb session.

I can't reproduce this after the load of patches I just pushed, so I'm
assuming one of them fixed it :)

> >> * XIGrabButton always fails with a BadDevice error.
> > 
> > Fixed, thanks. The check was in there to prevent passive grabbing of
> > attaches slave devices, which in hindsight might have its use-cases though
> > dealing with the modifiers can be trick. Documented in inputproto.
> It seems like XIGrabButton doesn't accept XIAnyModifier.  

this part was simply missing. It's implemented now and works.
Also, a passive grab on XIAllDevices and XIAllMasterDevices works now.

> Also, the example code in xinput uses an older incompatible interface
> (patch attached).

oops. I fixed this at least three times but each time forgot to push. sorry.
pushed now.

> If XIGrabButton is called on a SD, the SD is not detached when the grab
> is activated.

fixed. SDs are now detached for passive grabs, except if an implicit passive
grab is activated.

> >> * libXi doens't support parallel builds (make -j2) anymore.
> > 
> > works fine for me, not sure what's going on there.
> 
> Okay, fair enough, this is not really important anyway.

actually, the reason for this could be a missing dependency in the man
pages. If you can reproduce this error, just check the Makefile.am for the
dependency setup for the file it fails on. I've tried triggering it but
without success.

Cheers,
  Peter