[PATCH] Additional pci-id for the nv driver

[Alberto Milone]

On Saturday 24 January 2009 01:02:37 you wrote:
> On Fri, 2009-01-23 at 09:16 -0800, Alberto Milone wrote:
> > Dear Aaron,
> >
> >
> > I've noticed that the "nv" driver is not automatically chosen for my
> > Geforce 7300 GT unless I don't specify the "nv" driver in the
> > xorg.conf.
>
> Sorry, now that I look at it some more, something else must be wrong.
> The 0x2E2 device ID should have hit the NVGetPCIXpressChip case in
> NVPciProbe:
>
>     const CARD32 id = ((dev->device_id & 0xfff0) == 0x00F0 ||
>                        (dev->device_id & 0xfff0) == 0x02E0) ?
>                       NVGetPCIXpressChip(dev) : dev->vendor_id << 16 |
> dev->device_id;
>
> and come up with 0x0393.  Can you please put a breakpoint there and see
> what went wrong?
>
> -- Aaron
>

That case loop works well. I made the driver print a warning line right after 
that point and this is the result:
(WW) NV: Detected device 0x10de0393 (GeForce 7300 GT) at 01 at 00:00:0

The problem is that pci-id of my card (02E2) is not in /usr/share/xserver-
xorg/pci/nv.ids

Without my patch:
:~$ grep 02E2 /usr/share/xserver-xorg/pci/*

With my patch:
:~$ grep 02E2 /usr/share/xserver-xorg/pci/*
/usr/share/xserver-xorg/pci/nv.ids:10DE02E2


:~$ lspci -n |grep 300
01:00.0 0300: 10de:02e2 (rev a2)

This is why, as you can see in autodetection.log X doesn't use "nv" for my 
card when no driver is specified in the xorg.conf. In manualdetection.log you 
can see what happens when I set the driver to "nv" manually.

The NVGetPCIXpressChip case is used when the driver is being loaded but we 
need to handle this before so that X knows which driver has to be used.

Regards,

Alberto
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg/attachments/20090124/a3e0bc20/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: autodetection.log
Type: text/x-log
Size: 50257 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090124/a3e0bc20/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: manualdetection.log
Type: text/x-log
Size: 47184 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090124/a3e0bc20/attachment-0001.bin>