[PATCH] Send out correct events in ProcXTestFakeInput

[Peter Hutterer]

On Fri, Jan 09, 2009 at 02:15:30AM -0500, Thomas Jaeger wrote:
> Thomas Jaeger wrote:
> 
> > Using the latest xserver from server-1.6 branch, when
> > XTestFakeRelativeMotionEvent is called with a delay parameter !=
> > CurrentTime, the client may crash under certain circumstances.  I've
> > also seen problems with the same symptons on earlier X servers, but I've
> > never been able to reproduce them.
> 
> Fixed by the attached patch.

thanks, pushed.

> 
> > event) and then replays the events.  The XTestFakeRelativeMotionEvent
> > call is necessary for other clients to be made aware of the current
> > pointer position, it would be nice if this call wasn't needed, see
> > http://lists.freedesktop.org/archives/xorg/2009-January/042039.html
> 
> Any thoughts on this one?

It's been sittin in my tree for a few days now but I'm still not 100% sure on
it. I need to write up a testcase first.

> From e5c1907cee52e13b290b3d6e6f5c2a64ad697cd3 Mon Sep 17 00:00:00 2001
> From: Thomas Jaeger <ThJaeger at gmail.com>
> Date: Fri, 9 Jan 2009 02:02:38 -0500
> Subject: [PATCH] Xext: Send out correct events in ProcXTestFakeInput
> 
> ---
>  Xext/xtest.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Xext/xtest.c b/Xext/xtest.c
> index 1290a23..a7f3830 100644
> --- a/Xext/xtest.c
> +++ b/Xext/xtest.c
> @@ -396,7 +396,7 @@ ProcXTestFakeInput(client)
>  
>      OsBlockSignals();
>      for (i = 0; i < nevents; i++)
> -        mieqEnqueue(dev, events->event);
> +        mieqEnqueue(dev, (events+i)->event);
>      OsReleaseSignals();
>  
>      return client->noClientException;
> -- 
> 1.6.0.4

Cheers,
  Peter