[PATCH] xkb: Set sane build time XKB defaults

Dan Nicholson dbn.lists at gmail.com
Wed Jan 7 08:27:39 PST 2009


On Wed, Jan 7, 2009 at 7:44 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> On Wed, Jan 07, 2009 at 06:14:44AM -0800, Dan Nicholson wrote:
>> Previously, DIX set the default XKB rules to "base, pc105, us" during
>> initialization. That has now been moved to the DDX in 9c5dd733, but only
>> covers Xorg. This makes the builtin XKB match the previous DIX defaults.
>> Also changes the fallback XKB path match the typical location, although
>> XKB_BASE_DIRECTORY is always set during configure.
>
> NAK of sorts: I'd like to fix this properly.  In particular, hardcoded
> paths are not the way.

Sure. However, as it stands on both master and 1.6-branch, all the DDX
except Xorg start with these defaults. So, they have an invalid
default model of "dflt" as far as I can tell. Also, the
XKB_BASE_DIRECTORY setting could be dropped from this patch. It's
always defined in configure, so the hardcoded /usr/share/X11/xkb
should never actually get used.

What did you have in mind to fix this properly?

--
Dan



More information about the xorg mailing list