[PATCH] Don't release passive grabs unless all buttons are up

[Keith Packard]

On Mon, 2009-01-05 at 16:07 +1000, Peter Hutterer wrote:

> Following up on that:
> Both the core protocol and the XI protocol spec state that a passive grab is
> to be released when all buttons are logically up, regardless of modifiers.
> This is where the magic number 5 comes in. Core allows for 5 buttons, XI
> allows for more.

That's a common misunderstanding -- the core protocol allows for up to
255 buttons, and the documentation for GrabButton is fairly clear about
waiting until *all* buttons are released, not just the five visible in
the mask.

I think this makes the solution fairly easy, right?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20090105/2e214676/attachment.pgp>