[PATCH] Count the number of logically down buttons in buttonsDown

Thomas Jaeger thjaeger at gmail.com
Mon Jan 5 08:59:06 PST 2009


Thomas Jaeger wrote:
>> This puts us in a difficult position. Core requires us to release the grab if,
>> say, only button 6 is down. XI requires us to maintain the grab.
>> I think we need a more complex solution than the one you proposed: test
>> whether the passive grab is a core or an XI grab and release depending on this
>> condition.
>> Something like 
>> if ((grab->coreGrab && !button->state) && ... ||
>>     (!grab->coreGrab && AllButtonsAreUp(b))
> 
Implemented in the attached patch.  I'm running these patches now, I'll
let you know if I see any issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Don-t-release-Xi-grabs-unless-all-buttons-are-up.patch
Type: text/x-patch
Size: 1442 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090105/e1fce119/attachment.bin>


More information about the xorg mailing list