libX11-6.2.1 and pkg-config 0.23

[Dan Nicholson]

On Thu, Feb 19, 2009 at 12:21 AM, Pedro Izecksohn
<pedro.izecksohn at gmail.com> wrote:
>  In libX11-6.2.1:
>
>  The configure piece below is wrong, (or pkg-config is buggy) because
>
> pkg-config --cflags xproto
>
>  prints a line-feed only and keysymdef.h exists in my system and it is in
> the right place.
>
>  I'm using pkg-config --version 0.23
>
> #
> # Find keysymdef.h
> #
> KEYSYMDEF=""
> for flag in $XPROTO_CFLAGS; do
>        echo checking arg "$flag"
>        case "$KEYSYMDEF" in
>        "")
>                case "$flag" in
>                -I*)
>                        dir="`echo "$flag" | sed 's/^-I//'`"
>                        file="$dir/X11/keysymdef.h"
>                        echo looking for "$file"
>                        if test -f "$file"; then
>                                KEYSYMDEF="$file"
>                        fi
>                        ;;
>                esac
>                ;;
>        esac
> done
> case "$KEYSYMDEF" in
> "")
>        { { echo "$as_me:$LINENO: error: \"Cannot find keysymdef.h\"" >&5
> echo "$as_me: error: \"Cannot find keysymdef.h\"" >&2;}
>   { (exit 1); exit 1; }; }
>        ;;
> esac

Yeah, this seems wrong. What it should do is:

includex11dir=`$PKG_CONFIG --variable=includex11dir xproto`
KEYSYMDEF="$includex11dir/keysymdef.h"
test -f "$KEYSYMDEF" || AC_MSG_ERROR([Cannot find keysymdef.h in
$includex11dir])

Or something like that.

--
Dan