[PATCH 1/9] Includes new structures and defined MACRO

[Ma, Ling]

 >-----Original Message-----
>From: Adam Jackson [mailto:ajax at nwnk.net] 
>Sent: 2009年2月14日 2:24
>To: Ma, Ling
>Cc: xorg at lists.freedesktop.org
>Subject: Re: [PATCH 1/9] Includes new structures and defined MACRO
>
>On Thu, 2009-02-12 at 14:59 +0800, Ma Ling wrote:
>
>> > > +struct cea_vendor_blk {
>> > > +  unsigned char ieee_id[3];
>> > > +  Uchar  portB:4;
>> > > +  Uchar  portA:4;
>> > > +  Uchar  portD:4;
>> > > +  Uchar  portC:4;
>> > > +  struct vendor_hdmi hdmi;
>> > > +};
>> > 
>> > I don't see the port bits mentioned in the base CEA spec, 
>at all.  Where
>> > are you getting this from?
>> Oh, I saw it in 8.3.2 HDMI Vendor-Specific Data Block (HDMI 
>VSDB) of HDMISpecification13a.pdf
>
>The name "cea_vendor_block" implies that it's a generic container for
>vendor block encodings.  Something more like:
>
>struct cea_vendor_block_hdmi {
>    unsigned char portB:4;
>    unsigned char portA:4;
>    unsigned char portD:4:
>    unsigned char portC:4;
>    unsigned char support_flags;
>    unsigned char max_tmds_clock;
>    unsigned char latency_present;
>    unsigned char video_latency;
>    unsigned char audio_latency;
>    unsigned char interlaced_video_latency;
>    unsigned char interlaced_audio_latency;
>};
>
>/* other vendor block types */
>
>struct cea_vendor_block {
>    unsigned char ieee_id[3];
>    union {
>        struct cea_vendor_block_hdmi hdmi;
>        /* any other vendor blocks we know about */
>    } u;
>};
>
>perhaps?
Good! I will fix.
>
>- ajax
>