Janitor/RFC: Xorg packages

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Fri Feb 6 10:23:28 PST 2009


  Some points that could be made better:

1. Get rid of configure options that should not be used,
   and are only useful for make distcheck. I think it
   may be one case where AC_SUBST() can have an
   important role in the proper solution?

2. Replace most gratuitous AC_SUBST(VAR) by usage
   of $(VAR) in the Makefile.am's. It not only allows
   using "%make VAR=someval", but also has the
   benefit of a cleaner configure.ac.

3. In video drivers configure.ac's, there is a lot of
   tests in the format:
   save_FOOFLAGS="$FOOFLAGS"
   AC_CHECK_DECL(SOME_DEFINE,
                 SOME_DEFINE=yes, SOME_DEFINE=no,
                 [#include "xorg-server.h"])
   <some-shell-code>
   FOOFLAGS="$save_FOOFLAGS"
   Maybe, xorg-macros should be extended, to have
   proper:
   XORG_LIBPCIACCESS
   XORG_XF1OR4BPP
   XORG_HASISA
   XORG_DRMSTUFF
   macros, and similar? To avoid too much cut&paste,
   and slightly different variants for every driver.

4. Have a global autogen.sh, provided by what? xorg-macros?

Paulo




More information about the xorg mailing list