xorg/driver/xf86-video-ast: [PATCH 1/2] Janitor: make distcheck, .gitignore.

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Fri Feb 6 09:42:56 PST 2009

Dan Nicholson wrote:
> I think I reviewed all the non-code patches and they looked fine
> except for a couple I replied on. Most of the warning fixes seemed
> fine to me, too, but I'd be lying if I said I was the master of the C
> specification or knowing the xserver SDK.


> So, I think you could push all the distcheck-type fixes. Especially
> for the unused drivers.
> One thing that would be nice is if you could inline the patches. That
> would make reviewing faster. Below is my git send-email cheat sheet if
> that helps. You can always play around with --dry-run and see if the
> right thing is being produced.

  I experimented a bit with git send-email (and git imap-send and
git request-pull as suggested in irc) before starting sending any
new patches. But I preferred, at least for the moment to attach
them so that it should work properly in any MUA, and make it easier
to edit the subject to add repository information.

> ~/.gitconfig settings
> [sendemail]
> 	bcc = dbn.lists at gmail.com
> 	chainreplyto = false
> 	smtpserver = smtp.gmail.com
> 	smtpssl = true
> 	smtpuser = dbn.lists at gmail.com
> 	suppresscc = self
> 	#signedoffcc = false
> 	#suppressfrom = true
> Single patch: (add --no-thread to skip prompt for Message-ID):
> git format-patch -s HEAD^
> git send-email --to $list 0001-*.patch
> Patch series from branch:
> git format-patch -n -s -o $patchdir --cover-letter master
> $EDITOR $patchdir/0000-cover-letter.patch
> git send-email --to $list $patchdir

  The problem is that it makes it too hard to fetch the "verbatim",
entire message if not using some specific MUAs.

  I talked to jcristau (after the problem where I did a cut&paste
of the announce message for libXext, and the webmail interface
was "smart enough to wrap lines" so that the pgp verification would
fail) that I considered to make xmh an usable MUA, why not? But I
don't think I would do it..., too much time and dedication required,
and I think I already invested enough of my "free time" in
Xaw and xedit in the past :-)


More information about the xorg mailing list