xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

Paulo César Pereira de Andrade pcpa at mandriva.com.br
Wed Feb 4 11:48:01 PST 2009


  These cases should really be addressed in a different
way, as the addition of a option that is only useful to
pass distcheck is wrong.

  Another "cosmetic" thing that should be addressed is
usage of something like:
PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)
AC_SUBST(XORG_CFLAGS)

  First the automake macro says:

Checking for XORG... yes

while it should say something more like:

Checking for xorg-server...
Checking for xproto...

or maybe in the same line, but not really a xorg issue,
but a pkg-config issue?


The AC_SUBST issue is because there is a lot of mixed usage
in Makefiles of @XORG_CFLAGS@ and $(XORG_CFLAGS)


Paulo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correct-make-distchek-using-the-same-solution-used-i.patch
Type: text/x-patch
Size: 1692 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090204/39674b23/attachment.bin>


More information about the xorg mailing list