about the exa patches

Michel Dänzer michel at daenzer.net
Tue Feb 3 23:32:41 PST 2009

On Wed, 2009-02-04 at 00:29 +0100, Maarten Maathuis wrote:
> I hope the changes are coming to an end. I still need to know if there
> are any external users of fbDoCopy that would care for a wrapper. I'm
> assuming that functions that changed their return value from void to
> Bool pose no issue, but you're welcome to explain if it's not.
> @MrCooper: the approach of patch 8 and 9 is ok by you?

I definitely like the reuse of fbCopyRegion and fbDoCopy; the only minor
niggle I have there would be to replace EXA_WRAPPER with something more
generic like FB_WRAP_PREFIX, and then

#define fbCopyRegion FB_WRAP_PREFIX##CopyRegion
#define fbDoCopy FB_WRAP_PREFIX##DoCopy

I'd like the fb changes to be reviewed by an fb hacker.

Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer

More information about the xorg mailing list