[PATCHES] remove direct access to fb module from exa
michel at daenzer.net
Mon Feb 2 05:35:12 PST 2009
On Mon, 2009-02-02 at 01:30 +0100, Maarten Maathuis wrote:
> On Sun, Feb 1, 2009 at 5:11 PM, Maarten Maathuis <madman2003 at gmail.com> wrote:
> > On Sun, Feb 1, 2009 at 1:16 PM, Maarten Maathuis <madman2003 at gmail.com> wrote:
> >> On Sun, Feb 1, 2009 at 3:40 AM, Maarten Maathuis <madman2003 at gmail.com> wrote:
> >>> In the spirit of correctness and wfb compatibility a few optimisations
> >>> had to go, but nothing serious.
> >>> I'll commit this soon'ish if there are no (serious) comments.
> >>> Maarten.
> >> This new patchset fixes exaValidateGC, so it only changes patch 0004.
> >> Maarten.
> > This time 6, 7 and 8 changed. Quite a serious bug actually. See the
> > comment in patch 6 for details.
> > Maarten.
> Forgot a few cases.
exaImageGlyphBlt served as damage control to avoid migration ping-pong
with core font rendering. It might be nice to benchmark this and see if
it's still relevant, and if so try to preserve it by calling down to the
lower layer and possibly copy some helper functions.
It looks like part of patch 6 fixes a problem introduced by a previous
patch? If so, just fix that patch directly, or at least split out that
part into a separate patch.
I'm slightly uneasy about copy'n'pasting large parts of fb code as in
patch 8, if possible it might be better to build the original code into
EXA, possibly with symbol mangling as required.
Otherwise looks good to me; so, does this allow you to use EXA with wfb?
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
More information about the xorg