Xserver function InitKeyboardDeviceStruct() does not use bell_func?

Peter Hutterer peter.hutterer at who-t.net
Sun Apr 19 23:43:29 PDT 2009


On Fri, Apr 17, 2009 at 03:14:45PM +0100, Colin Harrison wrote:
> Hi,
> 
> InitKeyboardDeviceStruct() does not use 'bell_func' in xserver/xkb/xkbInit.c
> git master.
> 
> I found that this was needed to get my DDX's bell to ring :)
> 
> --- ./xkb/save_xkbInit.c        2009-04-17 07:41:36.000000000 +0100
> +++ ./xkb/xkbInit.c     2009-04-17 15:00:12.000000000 +0100
> @@ -576,6 +576,7 @@ InitKeyboardDeviceStruct(DeviceIntPtr de
>      InitFocusClassDeviceStruct(dev);
> 
>      xkbi->kbdProc = ctrl_func;
> +    dev->kbdfeed->BellProc = bell_func;
>      dev->kbdfeed->CtrlProc = XkbDDXKeybdCtrlProc;
> 
>      dev->kbdfeed->ctrl = defaultKeyboardControl;
> 
> A useful fix, perhaps, until I know better.

pushed, thanks.
please submit future patches as git-formatted patches, it makes life easier
for the maintainers. See also
http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches
 
Cheers,
  Peter



More information about the xorg mailing list