xf86-video-savage: (2/2) Do not use XAAGetCopyROP outside of XAA-specific code

[Alex Villací­s Lasso]

The DRI code attempts to use XAAGetCopyROP without checking whether XAA 
or EXA is in effect. This results in the server crashing with an 
undefined-symbol error when enabling EXA, then starting glxgears under 
GNOME/Metacity and attempting to drag the glxgears window.

The EXA code happens to have a functional duplicate of the required code 
under the name SavageGetCopyROP(). This patch moves the code to 
savage_accel.c where it is now shared between EXA and the DRI code.

It is disturbing that this has not been caught before...

Just out of curiosity, how many subscribers of this list have access to 
a Savage chipset, besides myself? Is the Savage EXA code being exercised 
in the wild?

I followed the steps at http://www.freedesktop.org/wiki/AccountRequests 
in order to get commit access for xf86-video-savage, and opened 
https://bugs.freedesktop.org/show_bug.cgi?id=20727 for the required 
information. No reply has yet been received. Is there anything else missing?

-- 
perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Do-not-use-XAAGetCopyROP-outside-of-XAA-specific-cod.patch
URL: <http://lists.x.org/archives/xorg/attachments/20090413/ba89636a/attachment.ksh>