current git head of Xserver segfaults on a keyhit

Lukas Hejtmanek xhejtman at ics.muni.cz
Tue Sep 23 01:25:12 PDT 2008


On Tue, Sep 23, 2008 at 09:16:06AM +0100, Johannes Engel wrote:
> Quoting Lukas Hejtmanek, On 09/22/2008 07:08 PM:
> > Hello,
> >
> > the current git head of the Xserver segfaults on any keystroke. Trace is
> > attached:
> Is that another manifestation of bug #16167?

depends whether this fix helps for you. But I have absolutely no idea why this
helps.

diff --git a/xkb/xkbUtils.c b/xkb/xkbUtils.c
index 486446a..0ad8898 100644
--- a/xkb/xkbUtils.c
+++ b/xkb/xkbUtils.c
@@ -470,8 +470,8 @@ CARD8                       keysPerMod[XkbNumModifiers];
     }
     keyc->maxKeysPerModifier= maxKeysPerMod;
 
-    if (maxSymsPerKey>0) {
-       tmp= maxSymsPerKey*_XkbCoreNumKeys(keyc);
+    if (maxSymsPerKey>0) {     
+       tmp= 8*_XkbCoreNumKeys(keyc);
        keyc->curKeySyms.map=
_XkbTypedRealloc(keyc->curKeySyms.map,tmp,KeySym);
        if (keyc->curKeySyms.map==NULL)
            FatalError("Couldn't allocate symbols map in UpdateCore\n");


-- 
Lukáš Hejtmánek



More information about the xorg mailing list