ProcPutImage calls exaDoMoveOutPixmap, 4x slowdown

Michel Dänzer michel at tungstengraphics.com
Tue Oct 21 09:34:01 PDT 2008


On Mon, 2008-10-20 at 09:59 -0400, Adam Jackson wrote:
> On Mon, 2008-10-20 at 13:08 +0200, Michel Dänzer wrote:
> > On Thu, 2008-10-16 at 13:54 -0400, Adam Jackson wrote:
> > > On Thu, 2008-10-16 at 08:02 -0700, Michel Dänzer wrote:
> > > > On Wed, 2008-10-15 at 21:59 +0200, Maarten Maathuis wrote:
> > > > > On Wed, Oct 15, 2008 at 9:43 PM, Eric Anholt <eric at anholt.net> wrote:
> > > > > >
> > > > > > Migrating out for a write-only operation is just broken, and is the
> > > > > > thing that should be fixed there.
> > > > 
> > > > There is no actual migration here, just superfluous syncing fixed by my
> > > > patch.
> > > 
> > > The patch looks plausible.  1.5 branch candidate?
> > 
> > Think so, though I haven't even got around to pushing it to master due
> > to travel and struggling with an input related server crash I hope to
> > post about shortly.
> 
> Applied to master, thanks.

Thanks for applying it.


> > > > > The current {Prepare,Finish}Access isn't completely
> > > > > suited for this conversion (exaPixmapIsOffscreen() isn't exported).
> > > > 
> > > > FWIW, exporting exaPixmapIsOffscreen() might make sense anyway though.
> > > 
> > > Yes please.
> > 
> > Anyone feel free to beat me to this and the above.
> 
> Actually we've already got exaDrawableIsOffscreen() in exa.h,

I see it in exa_priv.h, like exaPixmapIsOffscreen().


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer




More information about the xorg mailing list