ProcPutImage calls exaDoMoveOutPixmap, 4x slowdown

Michel Dänzer michel at tungstengraphics.com
Thu Oct 16 08:02:42 PDT 2008


On Wed, 2008-10-15 at 21:59 +0200, Maarten Maathuis wrote:
> On Wed, Oct 15, 2008 at 9:43 PM, Eric Anholt <eric at anholt.net> wrote:
> >
> > Migrating out for a write-only operation is just broken, and is the
> > thing that should be fixed there.

There is no actual migration here, just superfluous syncing fixed by my
patch.


> I'd like to add that if anything changes in this beheaviour, then this
> shouldn't be done quietly. Because some may depend on this (offscreen
> memory tiled and needing migration to have something linear available
> for example). 

Sounds like something that could be handled in UploadToScreen.

> The current {Prepare,Finish}Access isn't completely
> suited for this conversion (exaPixmapIsOffscreen() isn't exported).

FWIW, exporting exaPixmapIsOffscreen() might make sense anyway though.


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer




More information about the xorg mailing list