To be sure, to be sure

Peter Hutterer peter.hutterer at who-t.net
Sat Oct 11 16:55:35 PDT 2008


On Sat, Oct 11, 2008 at 03:27:48PM +0100, Colin Harrison wrote:
> There is a double up of some code in dix/events.c, function
> ReleaseActiveGrabs(), that may give
> trouble?
> 
> at about line 1920
> 
>             if (dev->deviceGrab.grab && SameClient(dev->deviceGrab.grab,
> client))
>             {
>                 (*dev->deviceGrab.DeactivateGrab)(dev);
>                 done = FALSE;
>             }

You're right, it needs to be removed. 
But it won't do any harm, as dev->deviceGrab.grab is NULL after the first call
to DeactivateGrab anyway, so this condition can never be triggered.
I got the patch in my tree, will find its way upstream soon.

Cheers,
  Peter



More information about the xorg mailing list