[PATCH] [pixmap] rename/convert devKind and devPrivate fields

Maarten Maathuis madman2003 at gmail.com
Wed Oct 8 10:20:53 PDT 2008


On Tue, Oct 7, 2008 at 8:04 PM, Maarten Maathuis <madman2003 at gmail.com> wrote:
> These names are supposedly historical, but everyone seems to use them
> for the same purpose.
> I am aware this may require a few minor changes to (for example) exa
> drivers with driver based memory allocations.
> I personally believe in having clear names rather than some obscure
> remnant of the past. I removed the devPrivate considering the void
> pointer is the only useful part anyway.
>
> It would be nice to know if all !xfree86 has the equivilant of
> VIDEODRV_ABI_VERSION.
>
> Anyway, share your thoughts, comments and such.
>
> Maarten.
>
> PS. i can commit these myself, this is just for review, considering
> it's a non-trivial change.
>

Any thoughts about other stuff needing change in the pixmap (or maybe
the closely related drawable)? I'm openminded to change, so it seems
sensible to check if there are any other problems out there. Without
any further complaints i'll probably go ahead with this in a few days.

Maarten



More information about the xorg mailing list