[PATCH 2/4] X event queue mutex

[Keith Packard]

On Fri, 2008-10-03 at 05:57 +0300, Daniel Stone wrote:
> On Thu, Oct 02, 2008 at 06:53:09PM -0700, Keith Packard wrote:
> > On Fri, 2008-10-03 at 02:01 +0200, Simon Thum wrote:
> > > (b) may suffice. Locking the queue in OsBlockSigs() should do it and fix 
> > > most miEnqueue users.
> > 
> > Or just lock the queue in mieqEnqueue itself; keeping the lock near the
> > code seems like a lot better plan to me.
> 
> Except if the lock is held across the entire event processing, because
> we need to queue events from event processing.

That makes it more important that the mutex cover precisely the values
which will be modified in multiple threads, inserting events into the
queue, and not pulling them out, which is done only in a single thread.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20081002/09b1d034/attachment.pgp>